Commit 6d3a4c40 authored Oct 06, 2016 by Geert Uytterhoeven Committed by David S. Miller Oct 12, 2016

strparser: Propagate correct error code in strp_recv()



With m68k-linux-gnu-gcc-4.1:

    net/strparser/strparser.c: In function ‘strp_recv’:
    net/strparser/strparser.c:98: warning: ‘err’ may be used uninitialized in this function

Pass "len" (which is an error code when negative) instead of the
uninitialized "err" variable to fix this.

Fixes: 43a0c675 ("strparser: Stream parser for messages")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 6b25e21f

net/strparser/strparser.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -246,7 +246,7 @@ static int strp_recv(read_descriptor_t desc, struct sk_buff orig_skb,
		} else {
		strp->rx_interrupted = 1;
		}
		strp_parser_err(strp, err, desc);
		strp_parser_err(strp, len, desc);
		break;
		} else if (len > strp->sk->sk_rcvbuf) {
		/* Message length exceeds maximum allowed */