Commit 6d210eef authored Feb 25, 2016 by Bhaktipriya Shridhar Committed by Greg Kroah-Hartman Mar 11, 2016

staging: rdma: hfi1: Remove useless return variables



This patch removes unnecessary return variables and compresses the
return logic.

The coccinelle script that finds and fixes this issue is:

@@ type T; identifier i,f; constant C; @@
- T i;
...when != i
when strict
( return -C;
|
- i =
+ return
f(...);
- return i;
)

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent c8843b1f

drivers/staging/rdma/hfi1/chip.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -1250,11 +1250,8 @@ CNTR_ELEM(#name, \

		u64 read_csr(const struct hfi1_devdata *dd, u32 offset)
		{
		u64 val;

		if (dd->flags & HFI1_PRESENT) {
		val = readq((void __iomem *)dd->kregbase + offset);
		return val;
		return readq((void __iomem *)dd->kregbase + offset);
		}
		return -1;
		}