Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6ce2357f authored by Bryan Schumaker's avatar Bryan Schumaker Committed by J. Bruce Fields
Browse files

NFSD: Remove unused variable from nfsd4_decode_bind_conn_to_session() 



Compiling gave me this warning:
fs/nfsd/nfs4xdr.c: In function ‘nfsd4_decode_bind_conn_to_session’:
fs/nfsd/nfs4xdr.c:427:6: warning: variable ‘dummy’ set but not used
[-Wunused-but-set-variable]

The local variable "dummy" wasn't being used past the READ32() macro that
set it.  READ_BUF() should ensure that the xdr buffer is pushed past the
data read into dummy already, so nothing needs to be read in.

Signed-off-by: default avatarBryan Schumaker <bjschuma@netapp.com>
[bfields@redhat.com: minor comment fixup.]
Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
parent 1db2b9dd

fs/nfsd/nfs4xdr.c

+2 −5
Original line number Diff line number Diff line
@@ -424,15 +424,12 @@ nfsd4_decode_access(struct nfsd4_compoundargs *argp, struct nfsd4_access *access 
static __be32 nfsd4_decode_bind_conn_to_session(struct nfsd4_compoundargs *argp, struct nfsd4_bind_conn_to_session *bcts)

{

	DECODE_HEAD;

	u32 dummy;



	READ_BUF(NFS4_MAX_SESSIONID_LEN + 8);

	COPYMEM(bcts->sessionid.data, NFS4_MAX_SESSIONID_LEN);

	READ32(bcts->dir);

	/* XXX: Perhaps Tom Tucker could help us figure out how we

	 * should be using ctsa_use_conn_in_rdma_mode: */

	READ32(dummy);



	/* XXX: skipping ctsa_use_conn_in_rdma_mode.  Perhaps Tom Tucker

	 * could help us figure out we should be using it. */

	DECODE_TAIL;

}