Commit 6b7a783e authored Feb 21, 2015 by NeilBrown Committed by Ulf Hansson Mar 19, 2015

mmc: pwrseq_simple: fix error path in mmc_pwrseq_simple_alloc



The current error-path code (when gpiod_get_index() reports
an error) can never free pwrseq->reset_gpios[0], but might
try to tree pwrseq->reset_gpios[-1], which has unfortunate
consequences.

Signed-off-by: NeilBrown <neil@brown.name>
Fixes: 934f1f48
Acked-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Reported-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

parent 06e5801b

drivers/mmc/core/pwrseq_simple.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -124,7 +124,7 @@ int mmc_pwrseq_simple_alloc(struct mmc_host host, struct device dev)
		PTR_ERR(pwrseq->reset_gpios[i]) != -ENOSYS) {
		ret = PTR_ERR(pwrseq->reset_gpios[i]);

		while (--i)
		while (i--)
		gpiod_put(pwrseq->reset_gpios[i]);

		goto clk_put;