Commit 6ada0043 authored Feb 28, 2020 by Dan Carpenter Committed by Greg Kroah-Hartman Apr 24, 2020

mtd: lpddr: Fix a double free in probe()

commit 4da0ea71ea934af18db4c63396ba2af1a679ef02 upstream.

This function is only called from lpddr_probe(). We free "lpddr" both
here and in the caller, so it's a double free. The best place to free
"lpddr" is in lpddr_probe() so let's delete this one.

Fixes: 8dc00439 ("[MTD] LPDDR qinfo probing.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20200228092554.o57igp3nqhyvf66t@kili.mountain

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent eb6f402b

drivers/mtd/lpddr/lpddr_cmds.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -81,7 +81,6 @@ struct mtd_info lpddr_cmdset(struct map_info map)
		shared = kmalloc(sizeof(struct flchip_shared) * lpddr->numchips,
		GFP_KERNEL);
		if (!shared) {
		kfree(lpddr);
		kfree(mtd);
		return NULL;
		}