Commit 6a515d6c authored Dec 14, 2020 by Vincent Stehlé Committed by Greg Kroah-Hartman Dec 29, 2020

net: korina: fix return value



[ Upstream commit 7eb000bdbe7c7da811ef51942b356f6e819b13ba ]

The ndo_start_xmit() method must not attempt to free the skb to transmit
when returning NETDEV_TX_BUSY. Therefore, make sure the
korina_send_packet() function returns NETDEV_TX_OK when it frees a packet.

Fixes: ef11291b ("Add support the Korina (IDT RC32434) Ethernet MAC")
Suggested-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20201214220952.19935-1-vincent.stehle@laposte.net


Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 619961f1

drivers/net/ethernet/korina.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -216,7 +216,7 @@ static int korina_send_packet(struct sk_buff skb, struct net_device dev)
		dev_kfree_skb_any(skb);
		spin_unlock_irqrestore(&lp->lock, flags);

		return NETDEV_TX_BUSY;
		return NETDEV_TX_OK;
		}
		}