Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 698f9755 authored by Radim Krčmář's avatar Radim Krčmář Committed by Paolo Bonzini
Browse files

KVM: x86: don't retry hopeless APIC delivery 



False from kvm_irq_delivery_to_apic_fast() means that we don't handle it
in the fast path, but we still return false in cases that were perfectly
handled, fix that.

Signed-off-by: default avatarRadim Krčmář <rkrcmar@redhat.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent decdc283

arch/x86/kvm/lapic.c

+2 −2
Original line number Diff line number Diff line
@@ -690,6 +690,8 @@ bool kvm_irq_delivery_to_apic_fast(struct kvm *kvm, struct kvm_lapic *src, 
	if (irq->dest_id == map->broadcast)

		goto out;



	ret = true;



	if (irq->dest_mode == 0) { /* physical mode */

		if (irq->delivery_mode == APIC_DM_LOWEST)

			goto out;
@@ -723,8 +725,6 @@ bool kvm_irq_delivery_to_apic_fast(struct kvm *kvm, struct kvm_lapic *src, 
			*r = 0;

		*r += kvm_apic_set_irq(dst[i]->vcpu, irq, dest_map);

	}



	ret = true;

out:

	rcu_read_unlock();

	return ret;