Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6897083a authored by Akinobu Mita's avatar Akinobu Mita Committed by Linus Torvalds
Browse files

[PATCH] dell_rbu: fix error check 



platform_device_register_simple() returns error code as pointer when it
fails.  The return value should be checked by IS_ERR().

Cc: Abhay Salunke <abhay_salunke@dell.com>
Signed-off-by: default avatarAkinobu Mita <akinobu.mita@gmail.com>
Cc: Matt Domsch <Matt_Domsch@dell.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 55aa601e

drivers/firmware/dell_rbu.c

+4 −5
Original line number Diff line number Diff line
@@ -705,17 +705,16 @@ static struct bin_attribute rbu_packet_size_attr = { 


static int __init dcdrbu_init(void)

{

	int rc = 0;

	int rc;

	spin_lock_init(&rbu_data.lock);



	init_packet_head();

	rbu_device =

		platform_device_register_simple("dell_rbu", -1, NULL, 0);

	if (!rbu_device) {

	rbu_device = platform_device_register_simple("dell_rbu", -1, NULL, 0);

	if (IS_ERR(rbu_device)) {

		printk(KERN_ERR

			"dell_rbu:%s:platform_device_register_simple "

			"failed\n", __FUNCTION__);

		return -EIO;

		return PTR_ERR(rbu_device);

	}



	rc = sysfs_create_bin_file(&rbu_device->dev.kobj, &rbu_data_attr);