Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 67a24ac1 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

netlink: fix lockdep splats 



With netlink_lookup() conversion to RCU, we need to use appropriate
rcu dereference in netlink_seq_socket_idx() & netlink_seq_next()

Reported-by: default avatarSasha Levin <sasha.levin@oracle.com>
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Fixes: e341694e ("netlink: Convert netlink_lookup() to use RCU protected hash table")
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 64a124ed

net/netlink/af_netlink.c

+2 −2
Original line number Diff line number Diff line
@@ -2899,7 +2899,7 @@ static struct sock *netlink_seq_socket_idx(struct seq_file *seq, loff_t pos) 


	for (i = 0; i < MAX_LINKS; i++) {

		struct rhashtable *ht = &nl_table[i].hash;

		const struct bucket_table *tbl = rht_dereference(ht->tbl, ht);

		const struct bucket_table *tbl = rht_dereference_rcu(ht->tbl, ht);



		for (j = 0; j < tbl->size; j++) {

			rht_for_each_entry_rcu(nlk, tbl->buckets[j], node) {
@@ -2950,7 +2950,7 @@ static void *netlink_seq_next(struct seq_file *seq, void *v, loff_t *pos) 


	do {

		struct rhashtable *ht = &nl_table[i].hash;

		const struct bucket_table *tbl = rht_dereference(ht->tbl, ht);

		const struct bucket_table *tbl = rht_dereference_rcu(ht->tbl, ht);



		for (; j < tbl->size; j++) {

			rht_for_each_entry_rcu(nlk, tbl->buckets[j], node) {