Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6789451f authored by Damien Le Moal's avatar Damien Le Moal Committed by Jaegeuk Kim
Browse files

f2fs: Fix use of number of devices 



For a single device mount using a zoned block device, the zone
information for the device is stored in the sbi->devs single entry
array and sbi->s_ndevs is set to 1. This differs from a single device
mount using a regular block device which does not allocate sbi->devs
and sets sbi->s_ndevs to 0.

However, sbi->s_devs == 0 condition is used throughout the code to
differentiate a single device mount from a multi-device mount where
sbi->s_ndevs is always larger than 1. This results in problems with
single zoned block device volumes as these are treated as multi-device
mounts but do not have the start_blk and end_blk information set. One
of the problem observed is skipping of zone discard issuing resulting in
write commands being issued to full zones or unaligned to a zone write
pointer.

Fix this problem by simply treating the cases sbi->s_ndevs == 0 (single
regular block device mount) and sbi->s_ndevs == 1 (single zoned block
device mount) in the same manner. This is done by introducing the
helper function f2fs_is_multi_device() and using this helper in place
of direct tests of sbi->s_ndevs value, improving code readability.

Fixes: 7bb3a371d199 ("f2fs: Fix zoned block device support")
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarDamien Le Moal <damien.lemoal@wdc.com>
Reviewed-by: default avatarChao Yu <yuchao0@huawei.com>
Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
parent 62a3a664

fs/f2fs/data.c

+11 −6
Original line number Diff line number Diff line
@@ -216,6 +216,7 @@ struct block_device *f2fs_target_device(struct f2fs_sb_info *sbi, 
	struct block_device *bdev = sbi->sb->s_bdev;

	int i;



	if (f2fs_is_multi_device(sbi)) {

		for (i = 0; i < sbi->s_ndevs; i++) {

			if (FDEV(i).start_blk <= blk_addr &&

			    FDEV(i).end_blk >= blk_addr) {
@@ -224,6 +225,7 @@ struct block_device *f2fs_target_device(struct f2fs_sb_info *sbi, 
				break;

			}

		}

	}

	if (bio) {

		bio->bi_bdev = bdev;

		bio->bi_iter.bi_sector = SECTOR_FROM_BLOCK(blk_addr);
@@ -235,6 +237,9 @@ int f2fs_target_device_index(struct f2fs_sb_info *sbi, block_t blkaddr) 
{

	int i;



	if (!f2fs_is_multi_device(sbi))

		return 0;



	for (i = 0; i < sbi->s_ndevs; i++)

		if (FDEV(i).start_blk <= blkaddr && FDEV(i).end_blk >= blkaddr)

			return i;

fs/f2fs/f2fs.h

+12 −1
Original line number Diff line number Diff line
@@ -1365,6 +1365,17 @@ static inline bool time_to_inject(struct f2fs_sb_info *sbi, int type) 
}

#endif



/*

 * Test if the mounted volume is a multi-device volume.

 *   - For a single regular disk volume, sbi->s_ndevs is 0.

 *   - For a single zoned disk volume, sbi->s_ndevs is 1.

 *   - For a multi-device volume, sbi->s_ndevs is always 2 or more.

 */

static inline bool f2fs_is_multi_device(struct f2fs_sb_info *sbi)

{

	return sbi->s_ndevs > 1;

}



/* For write statistics. Suppose sector size is 512 bytes,

 * and the return value is in kbytes. s is of struct f2fs_sb_info.

 */
@@ -3642,7 +3653,7 @@ static inline bool f2fs_force_buffered_io(struct inode *inode, 


	if (f2fs_post_read_required(inode))

		return true;

	if (sbi->s_ndevs)

	if (f2fs_is_multi_device(sbi))

		return true;

	/*

	 * for blkzoned device, fallback direct IO to buffered IO, so

fs/f2fs/file.c

+1 −1
Original line number Diff line number Diff line
@@ -2569,7 +2569,7 @@ static int f2fs_ioc_flush_device(struct file *filp, unsigned long arg) 
							sizeof(range)))

		return -EFAULT;



	if (sbi->s_ndevs <= 1 || sbi->s_ndevs - 1 <= range.dev_num ||

	if (!f2fs_is_multi_device(sbi) || sbi->s_ndevs - 1 <= range.dev_num ||

			__is_large_section(sbi)) {

		f2fs_msg(sbi->sb, KERN_WARNING,

			"Can't flush %u in %d for segs_per_sec %u != 1\n",

fs/f2fs/gc.c

+1 −1
Original line number Diff line number Diff line
@@ -1346,7 +1346,7 @@ void f2fs_build_gc_manager(struct f2fs_sb_info *sbi) 
	sbi->gc_pin_file_threshold = DEF_GC_FAILED_PINNED_FILES;



	/* give warm/cold data area from slower device */

	if (sbi->s_ndevs && !__is_large_section(sbi))

	if (f2fs_is_multi_device(sbi) && !__is_large_section(sbi))

		SIT_I(sbi)->last_victim[ALLOC_NEXT] =

				GET_SEGNO(sbi, FDEV(0).end_blk) + 1;

}

fs/f2fs/segment.c

+7 −6
Original line number Diff line number Diff line
@@ -580,7 +580,7 @@ static int submit_flush_wait(struct f2fs_sb_info *sbi, nid_t ino) 
	int ret = 0;

	int i;



	if (!sbi->s_ndevs)

	if (!f2fs_is_multi_device(sbi))

		return __submit_flush_wait(sbi, sbi->sb->s_bdev);



	for (i = 0; i < sbi->s_ndevs; i++) {
@@ -648,7 +648,8 @@ int f2fs_issue_flush(struct f2fs_sb_info *sbi, nid_t ino) 
		return ret;

	}



	if (atomic_inc_return(&fcc->queued_flush) == 1 || sbi->s_ndevs > 1) {

	if (atomic_inc_return(&fcc->queued_flush) == 1 ||

	    f2fs_is_multi_device(sbi)) {

		ret = submit_flush_wait(sbi, ino);

		atomic_dec(&fcc->queued_flush);
@@ -754,7 +755,7 @@ int f2fs_flush_device_cache(struct f2fs_sb_info *sbi) 
{

	int ret = 0, i;



	if (!sbi->s_ndevs)

	if (!f2fs_is_multi_device(sbi))

		return 0;



	for (i = 1; i < sbi->s_ndevs; i++) {
@@ -1365,7 +1366,7 @@ static int __queue_discard_cmd(struct f2fs_sb_info *sbi, 


	trace_f2fs_queue_discard(bdev, blkstart, blklen);



	if (sbi->s_ndevs) {

	if (f2fs_is_multi_device(sbi)) {

		int devi = f2fs_target_device_index(sbi, blkstart);



		blkstart -= FDEV(devi).start_blk;
@@ -1728,7 +1729,7 @@ static int __f2fs_issue_discard_zone(struct f2fs_sb_info *sbi, 
	block_t lblkstart = blkstart;

	int devi = 0;



	if (sbi->s_ndevs) {

	if (f2fs_is_multi_device(sbi)) {

		devi = f2fs_target_device_index(sbi, blkstart);

		blkstart -= FDEV(devi).start_blk;

	}
@@ -3086,7 +3087,7 @@ static void update_device_state(struct f2fs_io_info *fio) 
	struct f2fs_sb_info *sbi = fio->sbi;

	unsigned int devidx;



	if (!sbi->s_ndevs)

	if (!f2fs_is_multi_device(sbi))

		return;



	devidx = f2fs_target_device_index(sbi, fio->new_blkaddr);