Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 676dcb8b authored by Andrew Morton's avatar Andrew Morton Committed by Linus Torvalds
Browse files

[PATCH] add bottom_half.h 



With CONFIG_SMP=n:

  drivers/input/ff-memless.c:384: warning: implicit declaration of function 'local_bh_disable'
  drivers/input/ff-memless.c:393: warning: implicit declaration of function 'local_bh_enable'

Really linux/spinlock.h should include linux/interrupt.h.  But interrupt.h
includes sched.h which will need spinlock.h.

So the patch breaks the _bh declarations out into a separate header and
includes it in both interrupt.h and spinlock.h.

Cc: "Randy.Dunlap" <rdunlap@xenotime.net>
Cc: Andi Kleen <ak@suse.de>
Cc: <stable@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 620034c8

include/linux/bottom_half.h

0 → 100644
+10 −0
Original line number Diff line number Diff line 
#ifndef _LINUX_BH_H

#define _LINUX_BH_H



extern void local_bh_disable(void);

extern void __local_bh_enable(void);

extern void _local_bh_enable(void);

extern void local_bh_enable(void);

extern void local_bh_enable_ip(unsigned long ip);



#endif /* _LINUX_BH_H */

include/linux/interrupt.h

+1 −6
Original line number Diff line number Diff line
@@ -11,6 +11,7 @@ 
#include <linux/hardirq.h>

#include <linux/sched.h>

#include <linux/irqflags.h>

#include <linux/bottom_half.h>

#include <asm/atomic.h>

#include <asm/ptrace.h>

#include <asm/system.h>
@@ -217,12 +218,6 @@ static inline void __deprecated save_and_cli(unsigned long *x) 
#define save_and_cli(x)	save_and_cli(&x)

#endif /* CONFIG_SMP */



extern void local_bh_disable(void);

extern void __local_bh_enable(void);

extern void _local_bh_enable(void);

extern void local_bh_enable(void);

extern void local_bh_enable_ip(unsigned long ip);



/* PLEASE, avoid to allocate new softirqs, if you need not _really_ high

   frequency threaded job scheduling. For almost all the purposes

   tasklets are more than enough. F.e. all serial device BHs et

include/linux/spinlock.h

+1 −0
Original line number Diff line number Diff line
@@ -52,6 +52,7 @@ 
#include <linux/thread_info.h>

#include <linux/kernel.h>

#include <linux/stringify.h>

#include <linux/bottom_half.h>



#include <asm/system.h>