Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 675fe097 authored by Devendra Naga's avatar Devendra Naga Committed by Greg Kroah-Hartman
Browse files

staging/crystalhd: unregister chardev when class_create fails in chd_dec_init_chdev 



we missed a unregiser_chrdev if the class_create and subsequent function calls / checks fail

Signed-off-by: default avatarDevendra Naga <develkernel412222@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3b2f1fbe

drivers/staging/crystalhd/crystalhd_lnx.c

+3 −1
Original line number Diff line number Diff line
@@ -375,7 +375,7 @@ static int __devinit chd_dec_init_chdev(struct crystalhd_adp *adp) 
	if (IS_ERR(crystalhd_class)) {

		rc = PTR_ERR(crystalhd_class);

		BCMLOG_ERR("failed to create class\n");

		goto fail;

		goto class_create_fail;

	}



	dev = device_create(crystalhd_class, NULL, MKDEV(adp->chd_dec_major, 0),
@@ -412,6 +412,8 @@ static int __devinit chd_dec_init_chdev(struct crystalhd_adp *adp) 
	device_destroy(crystalhd_class, MKDEV(adp->chd_dec_major, 0));

device_create_fail:

	class_destroy(crystalhd_class);

class_create_fail:

	unregister_chrdev(adp->chd_dec_major, CRYSTALHD_API_NAME);

fail:

	return rc;

}