Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 66f95c35 authored by Lendacky, Thomas's avatar Lendacky, Thomas Committed by David S. Miller
Browse files

amd-xgbe: Resolve checkpatch warning about sscanf usage 



Checkpatch issued a warning preferring to use kstrto<type> when
using a single variable sscanf.  Change the sscanf invocation to
a kstrtouint call.

Signed-off-by: default avatarTom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b85e4d89

drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c

+4 −5
Original line number Diff line number Diff line
@@ -151,7 +151,7 @@ static ssize_t xgbe_common_write(const char __user *buffer, size_t count, 
{

	char workarea[32];

	ssize_t len;

	unsigned int scan_value;

	int ret;



	if (*ppos != 0)

		return 0;
@@ -165,10 +165,9 @@ static ssize_t xgbe_common_write(const char __user *buffer, size_t count, 
		return len;



	workarea[len] = '\0';

	if (sscanf(workarea, "%x", &scan_value) == 1)

		*value = scan_value;

	else

		return -EIO;

	ret = kstrtouint(workarea, 0, value);

	if (ret)

		return ret;



	return len;

}