Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 665bba10 authored by Pavel Emelyanov's avatar Pavel Emelyanov Committed by David S. Miller
Browse files

[NETFILTER/RXRPC]: Don't use seq_release_private where inappropriate. 



Some netfilter code and rxrpc one use seq_open() to open
a proc file, but seq_release_private to release one.

This is harmless, but ambiguous.

Signed-off-by: default avatarPavel Emelyanov <xemul@openvz.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c20932d2

net/ipv4/netfilter/nf_conntrack_l3proto_ipv4_compat.c

+1 −1
Original line number Diff line number Diff line
@@ -379,7 +379,7 @@ static const struct file_operations ct_cpu_seq_fops = { 
	.open    = ct_cpu_seq_open,

	.read    = seq_read,

	.llseek  = seq_lseek,

	.release = seq_release_private,

	.release = seq_release,

};



int __init nf_conntrack_ipv4_compat_init(void)

net/netfilter/nf_conntrack_standalone.c

+1 −1
Original line number Diff line number Diff line
@@ -293,7 +293,7 @@ static const struct file_operations ct_cpu_seq_fops = { 
	.open	 = ct_cpu_seq_open,

	.read	 = seq_read,

	.llseek	 = seq_lseek,

	.release = seq_release_private,

	.release = seq_release,

};

#endif /* CONFIG_PROC_FS */

net/rxrpc/ar-proc.c

+2 −2
Original line number Diff line number Diff line
@@ -103,7 +103,7 @@ const struct file_operations rxrpc_call_seq_fops = { 
	.open		= rxrpc_call_seq_open,

	.read		= seq_read,

	.llseek		= seq_lseek,

	.release	= seq_release_private,

	.release	= seq_release,

};



/*
@@ -188,5 +188,5 @@ const struct file_operations rxrpc_connection_seq_fops = { 
	.open		= rxrpc_connection_seq_open,

	.read		= seq_read,

	.llseek		= seq_lseek,

	.release	= seq_release_private,

	.release	= seq_release,

};