Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 644f17ad authored by Mika Westerberg's avatar Mika Westerberg Committed by Rafael J. Wysocki
Browse files

ACPI / PM: allow child devices to ignore parent power state 



Some serial buses like I2C and SPI don't require that the parent device is
in D0 before any of its children transitions to D0, but instead the parent
device can control its own power independently from the children.

This does not follow the ACPI specification as it requires the parent to be
powered on before its children. However, Windows seems to ignore this
requirement so I think we can do the same in Linux.

Implement this by adding a new power flag 'ignore_parent' to struct
acpi_device.  If this flag is set the ACPI core ignores checking of the
parent device power state when the device is powered on/off.

Signed-off-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 360818b8

drivers/acpi/device_pm.c

+5 −3
Original line number Diff line number Diff line
@@ -118,9 +118,10 @@ int acpi_device_get_power(struct acpi_device *device, int *state) 
	/*

	 * If we were unsure about the device parent's power state up to this

	 * point, the fact that the device is in D0 implies that the parent has

	 * to be in D0 too.

	 * to be in D0 too, except if ignore_parent is set.

	 */

	if (device->parent && device->parent->power.state == ACPI_STATE_UNKNOWN

	if (!device->power.flags.ignore_parent && device->parent

	    && device->parent->power.state == ACPI_STATE_UNKNOWN

	    && result == ACPI_STATE_D0)

		device->parent->power.state = ACPI_STATE_D0;
@@ -177,7 +178,8 @@ int acpi_device_set_power(struct acpi_device *device, int state) 
			 acpi_power_state_string(state));

		return -ENODEV;

	}

	if (device->parent && (state < device->parent->power.state)) {

	if (!device->power.flags.ignore_parent &&

	    device->parent && (state < device->parent->power.state)) {

		dev_warn(&device->dev,

			 "Cannot transition to power state %s for parent in %s\n",

			 acpi_power_state_string(state),

include/acpi/acpi_bus.h

+2 −1
Original line number Diff line number Diff line
@@ -222,7 +222,8 @@ struct acpi_device_power_flags { 
	u32 power_resources:1;	/* Power resources */

	u32 inrush_current:1;	/* Serialize Dx->D0 */

	u32 power_removed:1;	/* Optimize Dx->D0 */

	u32 reserved:28;

	u32 ignore_parent:1;	/* Power is independent of parent power state */

	u32 reserved:27;

};



struct acpi_device_power_state {