Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 631b84c5 authored by Emmanuel Grumbach's avatar Emmanuel Grumbach Committed by Wey-Yi Guy
Browse files

iwlwifi: add debug in Tx path in AGG flow 



This will allow us to catch bad cases in which the packets aren't in
the right place on the ring.

Signed-off-by: default avatarEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: default avatarWey-Yi Guy <wey-yi.w.guy@intel.com>
parent 855c2ee8

drivers/net/wireless/iwlwifi/iwl-trans-pcie-tx.c

+1 −0
Original line number Diff line number Diff line
@@ -408,6 +408,7 @@ static void iwlagn_tx_queue_stop_scheduler(struct iwl_trans *trans, u16 txq_id) 
void iwl_trans_set_wr_ptrs(struct iwl_trans *trans,

				int txq_id, u32 index)

{

	IWL_DEBUG_TX_QUEUES(trans, "Q %d  WrPtr: %d", txq_id, index & 0xff);

	iwl_write_direct32(bus(trans), HBUS_TARG_WRPTR,

			(index & 0xff) | (txq_id << 8));

	iwl_write_prph(bus(trans), SCD_QUEUE_RDPTR(txq_id), index);

drivers/net/wireless/iwlwifi/iwl-trans-pcie.c

+13 −0
Original line number Diff line number Diff line
@@ -1063,6 +1063,7 @@ static int iwl_trans_pcie_tx(struct iwl_trans *trans, struct sk_buff *skb, 
	bool is_agg = false;

	__le16 fc = hdr->frame_control;

	u8 hdr_len = ieee80211_hdrlen(fc);

	u16 __maybe_unused wifi_seq;



	/*

	 * Send this frame after DTIM -- there's a special queue
@@ -1093,6 +1094,18 @@ static int iwl_trans_pcie_tx(struct iwl_trans *trans, struct sk_buff *skb, 
	txq = &trans_pcie->txq[txq_id];

	q = &txq->q;



	/* In AGG mode, the index in the ring must correspond to the WiFi

	 * sequence number. This is a HW requirements to help the SCD to parse

	 * the BA.

	 * Check here that the packets are in the right place on the ring.

	 */

#ifdef CONFIG_IWLWIFI_DEBUG

	wifi_seq = SEQ_TO_SN(le16_to_cpu(hdr->seq_ctrl));

	WARN_ONCE(is_agg && ((wifi_seq & 0xff) != q->write_ptr),

		  "Q: %d WiFi Seq %d tfdNum %d",

		  txq_id, wifi_seq, q->write_ptr);

#endif



	/* Set up driver data for this TFD */

	txq->skbs[q->write_ptr] = skb;

	txq->cmd[q->write_ptr] = dev_cmd;