Commit 62f6536a authored Feb 17, 2012 by Nikunj A. Dadhania Committed by Ingo Molnar Feb 22, 2012

sched: Remove rcu_read_lock/unlock() from select_idle_sibling()



select_idle_sibling() is called from select_task_rq_fair(), which
already has the RCU read lock held.

Signed-off-by: Nikunj A. Dadhania <nikunj@linux.vnet.ibm.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20120217030409.11748.12491.stgit@abhimanyu


Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent 9388dc30

kernel/sched/fair.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -2670,8 +2670,6 @@ static int select_idle_sibling(struct task_struct *p, int target)
		/*
		* Otherwise, iterate the domains and find an elegible idle cpu.
		*/
		rcu_read_lock();

		sd = rcu_dereference(per_cpu(sd_llc, target));
		for_each_lower_domain(sd) {
		sg = sd->groups;
		@@ -2693,8 +2691,6 @@ static int select_idle_sibling(struct task_struct *p, int target)
		} while (sg != sd->groups);
		}
		done:
		rcu_read_unlock();

		return target;
		}