Commit 62c0e9c3 authored Mar 13, 2017 by Matthias Kaehlcke Committed by Greg Kroah-Hartman Feb 27, 2019

hpet: Make cmd parameter of hpet_ioctl_common() unsigned



commit 5cd5e6ad0ede862432e1e766bfe02a9ad447533e upstream.

The value passed by the two callers of the function is unsigned anyway.

Making the parameter unsigned fixes the following warning when building
with clang:

drivers/char/hpet.c:588:7: error: overflow converting case value to switch condition type (2149083139 to 18446744071563667459) [-Werror,-Wswitch]
        case HPET_INFO:
             ^
include/uapi/linux/hpet.h:18:19: note: expanded from macro 'HPET_INFO'
                        ^
include/uapi/asm-generic/ioctl.h:77:28: note: expanded from macro '_IOR'
                                ^
include/uapi/asm-generic/ioctl.h:66:2: note: expanded from macro '_IOC'
        (((dir)  << _IOC_DIRSHIFT) | \

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Acked-by: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 9e3bd868

drivers/char/hpet.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -574,7 +574,7 @@ static inline unsigned long hpet_time_div(struct hpets *hpets,
		}

		static int
		hpet_ioctl_common(struct hpet_dev *devp, int cmd, unsigned long arg,
		hpet_ioctl_common(struct hpet_dev *devp, unsigned int cmd, unsigned long arg,
		struct hpet_info *info)
		{
		struct hpet_timer __iomem *timer;