Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 626b9da0 authored by Dmitry Torokhov's avatar Dmitry Torokhov
Browse files

Input: ALPS - fix confusing comment in protocol data 



The comment about suspicions entry 0x20, 0x02, 0x0e has over time drifted
away and it become hard to figure out what it meant. Let's move it back so
it is clear.

Reported-by: default avatarPali Rohár <pali.rohar@gmail.com>
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 04aae283

drivers/input/mouse/alps.c

+8 −7
Original line number Diff line number Diff line
@@ -117,7 +117,14 @@ static const struct alps_model_info alps_model_data[] = { 
	{ { 0x73, 0x00, 0x0a }, 0x00, { ALPS_PROTO_V2, 0xf8, 0xf8, ALPS_DUALPOINT } },		/* ThinkPad R61 8918-5QG */

	{ { 0x73, 0x02, 0x0a }, 0x00, { ALPS_PROTO_V2, 0xf8, 0xf8, 0 } },

	{ { 0x73, 0x02, 0x14 }, 0x00, { ALPS_PROTO_V2, 0xf8, 0xf8, ALPS_FW_BK_2 } },		/* Ahtec Laptop */

	{ { 0x20, 0x02, 0x0e }, 0x00, { ALPS_PROTO_V2, 0xf8, 0xf8, ALPS_PASS | ALPS_DUALPOINT } },	/* XXX */



	/*

	 * XXX This entry is suspicious. First byte has zero lower nibble,

	 * which is what a normal mouse would report. Also, the value 0x0e

	 * isn't valid per PS/2 spec.

	 */

	{ { 0x20, 0x02, 0x0e }, 0x00, { ALPS_PROTO_V2, 0xf8, 0xf8, ALPS_PASS | ALPS_DUALPOINT } },



	{ { 0x22, 0x02, 0x0a }, 0x00, { ALPS_PROTO_V2, 0xf8, 0xf8, ALPS_PASS | ALPS_DUALPOINT } },

	{ { 0x22, 0x02, 0x14 }, 0x00, { ALPS_PROTO_V2, 0xff, 0xff, ALPS_PASS | ALPS_DUALPOINT } },	/* Dell Latitude D600 */

	/* Dell Latitude E5500, E6400, E6500, Precision M4400 */
@@ -151,12 +158,6 @@ static void alps_set_abs_params_st(struct alps_data *priv, 
static void alps_set_abs_params_mt(struct alps_data *priv,

				   struct input_dev *dev1);



/*

 * XXX - this entry is suspicious. First byte has zero lower nibble,

 * which is what a normal mouse would report. Also, the value 0x0e

 * isn't valid per PS/2 spec.

 */



/* Packet formats are described in Documentation/input/alps.txt */



static bool alps_is_valid_first_byte(struct alps_data *priv,