Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6203300e authored Aug 13, 2008 by Christoph Hellwig Committed by Lachlan McIlroy Aug 13, 2008

[XFS] don't call xfs_freesb from xfs_unmountfs



xfs_readsb is called before xfs_mount so xfs_freesb should be called after
xfs_unmountfs, too. This means it now happens after a few things during
the of xfs_unmount which all have nothing to do with the superblock.

SGI-PV: 981498

SGI-Modid: xfs-linux-melb:xfs-kern:31835a

Signed-off-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>

parent 41b5c2e7

fs/xfs/linux-2.6/xfs_super.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1147,6 +1147,7 @@ xfs_fs_put_super(
		}

		xfs_unmountfs(mp);
		xfs_freesb(mp);
		xfs_icsb_destroy_counters(mp);
		xfs_close_devices(mp);
		xfs_qmops_put(mp);
		@@ -1803,7 +1804,7 @@ xfs_fs_fill_super(
		WARN_ON(error);

		xfs_unmountfs(mp);
		goto out_free_fsname;
		goto out_free_sb;
		}

		STATIC int

fs/xfs/xfs_mount.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -1296,8 +1296,6 @@ xfs_unmountfs(
		xfs_unmountfs_wait(mp); /* wait for async bufs */
		xfs_log_unmount(mp); /* Done! No more fs ops. */

		xfs_freesb(mp);

		/*
		* All inodes from this mount point should be freed.
		*/