Commit 61ca94fa authored Mar 21, 2022 by Jakob Koschel Committed by Greg Kroah-Hartman Jun 14, 2022

staging: greybus: codecs: fix type confusion of list iterator variable



[ Upstream commit 84ef256550196bc06e6849a34224c998b45bd557 ]

If the list does not exit early then data == NULL and 'module' does not
point to a valid list element.
Using 'module' in such a case is not valid and was therefore removed.

Fixes: 6dd67645 ("greybus: audio: Use single codec driver registration")
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Vaibhav Agarwal <vaibhav.sr@gmail.com>
Reviewed-by: Mark Greer <mgreer@animalcreek.com>
Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
Link: https://lore.kernel.org/r/20220321123626.3068639-1-jakobkoschel@gmail.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 4063e2fe

drivers/staging/greybus/audio_codec.c

+2 −2

Original line number	Original line	Diff line number	Diff line
	@@ -618,8 +618,8 @@ static int gbcodec_mute_stream(struct snd_soc_dai *dai, int mute, int stream)
	break;		break;
	}		}
	if (!data) {		if (!data) {
	dev_err(dai->dev, "%s:%s DATA connection missing\n",		dev_err(dai->dev, "%s DATA connection missing\n",
	dai->name, module->name);		dai->name);
	mutex_unlock(&codec->lock);		mutex_unlock(&codec->lock);
	return -ENODEV;		return -ENODEV;
	}		}