Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 618aa106 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

USB: garmin_gps: fix memory leak on disconnect 



Remove bogus disconnect test introduced by 95bef012 ("USB: more serial
drivers writing after disconnect") which prevented queued data from
being freed on disconnect.

The possible IO it was supposed to prevent is long gone.

Cc: stable <stable@vger.kernel.org>
Signed-off-by: default avatarJohan Hovold <jhovold@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent cb25505f

drivers/usb/serial/garmin_gps.c

+1 −6
Original line number Diff line number Diff line
@@ -956,9 +956,6 @@ static void garmin_close(struct usb_serial_port *port) 
	if (!serial)

		return;



	mutex_lock(&port->serial->disc_mutex);



	if (!port->serial->disconnected)

	garmin_clear(garmin_data_p);



	/* shutdown our urbs */
@@ -968,8 +965,6 @@ static void garmin_close(struct usb_serial_port *port) 
	/* keep reset state so we know that we must start a new session */

	if (garmin_data_p->state != STATE_RESET)

		garmin_data_p->state = STATE_DISCONNECTED;



	mutex_unlock(&port->serial->disc_mutex);

}