Commit 60d87733 authored Nov 21, 2009 by Julia Lawall Committed by Sage Weil Nov 21, 2009

fs/ceph: introduce missing kfree

Error handling code following a kmalloc should free the allocated data.

The semantic match that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/

)

// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,f1,l;
position p1,p2;
expression *ptr != NULL;
@@

x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
<... when != x
     when != if (...) { <+...x...+> }
(
x->f1 = E
|
 (x->f1 == NULL || ...)
|
 f(...,x->f1,...)
)
...>
(
 return \(0\|<+...x...+>\|ptr\);
|
 return@p2 ...;
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Sage Weil <sage@newdream.net>

parent b19a29af

fs/ceph/xattr.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -655,8 +655,10 @@ static int ceph_sync_setxattr(struct dentry dentry, const char name,
		/* do request */
		req = ceph_mdsc_create_request(mdsc, CEPH_MDS_OP_SETXATTR,
		USE_AUTH_MDS);
		if (IS_ERR(req))
		return PTR_ERR(req);
		if (IS_ERR(req)) {
		err = PTR_ERR(req);
		goto out;
		}
		req->r_inode = igrab(inode);
		req->r_inode_drop = CEPH_CAP_XATTR_SHARED;
		req->r_num_caps = 1;