Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 60ad07ab authored by Szymon Janc's avatar Szymon Janc Committed by Samuel Ortiz
Browse files

NFC: pn533: Fix missing lock while operating on commands list 



In pn533_wq_cmd command was removed from list without cmd_lock held
(race with pn533_send_cmd_frame_async) which could lead to list
corruption. Delete command from list before releasing lock.

Signed-off-by: default avatarSzymon Janc <szymon.janc@tieto.com>
Signed-off-by: default avatarSamuel Ortiz <sameo@linux.intel.com>
parent 16a78e9f

drivers/nfc/pn533.c

+2 −1
Original line number Diff line number Diff line
@@ -698,13 +698,14 @@ static void pn533_wq_cmd(struct work_struct *work) 


	cmd = list_first_entry(&dev->cmd_queue, struct pn533_cmd, queue);



	list_del(&cmd->queue);



	mutex_unlock(&dev->cmd_lock);



	__pn533_send_cmd_frame_async(dev, cmd->out_frame, cmd->in_frame,

				     cmd->in_frame_len, cmd->cmd_complete,

				     cmd->arg, cmd->flags);



	list_del(&cmd->queue);

	kfree(cmd);

}