Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 600e9b49 authored by Liang Zhen's avatar Liang Zhen Committed by Greg Kroah-Hartman
Browse files

staging: lustre: fix failure handle of create reply 



error handler of lnet_create_reply_msg() didn't release lnet_res_lock
if lnet_msg_alloc() failed.
It can be fixed by moving validation check of msg out from lock.

Signed-off-by: default avatarLiang Zhen <liang.zhen@intel.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-2745
Reviewed-on: http://review.whamcloud.com/5542


Reviewed-by: default avatarDoug Oucharek <doug.s.oucharek@intel.com>
Reviewed-by: default avatarIsaac Huang <he.huang@intel.com>
Reviewed-by: default avatarOleg Drokin <oleg.drokin@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4ee23a84

drivers/staging/lustre/lnet/lnet/lib-move.c

+5 −5
Original line number Diff line number Diff line
@@ -2187,17 +2187,17 @@ lnet_create_reply_msg(lnet_ni_t *ni, lnet_msg_t *getmsg) 
	LASSERT(!getmsg->msg_target_is_router);

	LASSERT(!getmsg->msg_routing);



	cpt = lnet_cpt_of_cookie(getmd->md_lh.lh_cookie);

	lnet_res_lock(cpt);



	LASSERT(getmd->md_refcount > 0);



	if (!msg) {

		CERROR("%s: Dropping REPLY from %s: can't allocate msg\n",

		       libcfs_nid2str(ni->ni_nid), libcfs_id2str(peer_id));

		goto drop;

	}



	cpt = lnet_cpt_of_cookie(getmd->md_lh.lh_cookie);

	lnet_res_lock(cpt);



	LASSERT(getmd->md_refcount > 0);



	if (!getmd->md_threshold) {

		CERROR("%s: Dropping REPLY from %s for inactive MD %p\n",

		       libcfs_nid2str(ni->ni_nid), libcfs_id2str(peer_id),