Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5fa146b2 authored by Heinz Mauelshagen's avatar Heinz Mauelshagen Committed by Mike Snitzer
Browse files

dm raid: reject too many write_mostly devices 



Signed-off-by: default avatarHeinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: default avatarMike Snitzer <snitzer@redhat.com>
parent 0a7b8188

drivers/md/dm-raid.c

+7 −1
Original line number Diff line number Diff line
@@ -1025,7 +1025,7 @@ static int parse_raid_params(struct raid_set *rs, struct dm_arg_set *as, 
{

	int value, raid10_format = ALGORITHM_RAID10_DEFAULT;

	unsigned raid10_copies = 2;

	unsigned i;

	unsigned i, write_mostly = 0;

	unsigned region_size = 0;

	sector_t max_io_len;

	const char *arg, *key;
@@ -1179,6 +1179,7 @@ static int parse_raid_params(struct raid_set *rs, struct dm_arg_set *as, 
				return -EINVAL;

			}



			write_mostly++;

			set_bit(WriteMostly, &rs->dev[value].rdev.flags);

			set_bit(__CTR_FLAG_WRITE_MOSTLY, &rs->ctr_flags);

		} else if (!strcasecmp(key, dm_raid_arg_name_by_flag(CTR_FLAG_MAX_WRITE_BEHIND))) {
@@ -1303,6 +1304,11 @@ static int parse_raid_params(struct raid_set *rs, struct dm_arg_set *as, 
		return -EINVAL;

	}



	if (write_mostly >= rs->md.raid_disks) {

		rs->ti->error = "Can't set all raid1 devices to write_mostly";

		return -EINVAL;

	}



	if (validate_region_size(rs, region_size))

		return -EINVAL;