Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5e4b08a7 authored by Marc Zyngier's avatar Marc Zyngier Committed by Greg Kroah-Hartman
Browse files

irqchip/alpine-msi: Fix freeing of interrupts on allocation error path 



[ Upstream commit 3841245e8498a789c65dedd7ffa8fb2fee2c0684 ]

The alpine-msi driver has an interesting allocation error handling,
where it frees the same interrupts repeatedly. Hilarity follows.

This code is probably never executed, but let's fix it nonetheless.

Fixes: e6b78f2c ("irqchip: Add the Alpine MSIX interrupt controller")
Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
Reviewed-by: default avatarAntoine Tenart <atenart@kernel.org>
Cc: Tsahee Zidenberg <tsahee@annapurnalabs.com>
Cc: Antoine Tenart <atenart@kernel.org>
Link: https://lore.kernel.org/r/20201129135525.396671-1-maz@kernel.org


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 03fb3c45

drivers/irqchip/irq-alpine-msi.c

+1 −2
Original line number Diff line number Diff line
@@ -165,8 +165,7 @@ static int alpine_msix_middle_domain_alloc(struct irq_domain *domain, 
	return 0;



err_sgi:

	while (--i >= 0)

		irq_domain_free_irqs_parent(domain, virq, i);

	irq_domain_free_irqs_parent(domain, virq, i - 1);

	alpine_msix_free_sgi(priv, sgi, nr_irqs);

	return err;

}