Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5e40b1c1 authored by Wei Yongjun's avatar Wei Yongjun Committed by Tony Lindgren
Browse files

gpio/omap: fix possible memory leak in omap2_gpio_dev_init() 

pdata and pdata->regs have been allocated in this function and
should be freed before leaving it, and in the other error handling
cases too.

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/

)

Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: default avatarKevin Hilman <khilman@ti.com>
Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
parent 55d512e2

arch/arm/mach-omap2/gpio.c

+2 −0
Original line number Diff line number Diff line
@@ -60,6 +60,7 @@ static int __init omap2_gpio_dev_init(struct omap_hwmod *oh, void *unused) 
	pdata->regs = kzalloc(sizeof(struct omap_gpio_reg_offs), GFP_KERNEL);

	if (!pdata->regs) {

		pr_err("gpio%d: Memory allocation failed\n", id);

		kfree(pdata);

		return -ENOMEM;

	}
@@ -121,6 +122,7 @@ static int __init omap2_gpio_dev_init(struct omap_hwmod *oh, void *unused) 
		break;

	default:

		WARN(1, "Invalid gpio bank_type\n");

		kfree(pdata->regs);

		kfree(pdata);

		return -EINVAL;

	}