Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5e081591 authored by Tao Ma's avatar Tao Ma Committed by Jens Axboe
Browse files

block: warn if tag is greater than real_max_depth. 



In case tag depth is reduced, it is max_depth not real_max_depth.
So we should allow a request with tag >= max_depth, but for a
tag >= real_max_depth, there really should be some problem.

Signed-off-by: default avatarTao Ma <boyu.mt@taobao.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 83157223

block/blk-tag.c

+4 −2
Original line number Diff line number Diff line
@@ -286,12 +286,14 @@ void blk_queue_end_tag(struct request_queue *q, struct request *rq) 


	BUG_ON(tag == -1);



	if (unlikely(tag >= bqt->real_max_depth))

	if (unlikely(tag >= bqt->max_depth)) {

		/*

		 * This can happen after tag depth has been reduced.

		 * FIXME: how about a warning or info message here?

		 * But tag shouldn't be larger than real_max_depth.

		 */

		WARN_ON(tag >= bqt->real_max_depth);

		return;

	}



	list_del_init(&rq->queuelist);

	rq->cmd_flags &= ~REQ_QUEUED;