Commit 5de6dfc8 authored Jan 09, 2015 by Vasanthakumar Thiagarajan Committed by Kalle Valo Jan 13, 2015

ath10k: Fix potential Rx ring corruption



When replenishing Rx buffers driver updates the address of the
buffer and the index of rx buffer in rx ring to the firmware.
Change in order by CPU can cause rx ring corruption. Add memory
barrier before updating rx buffer index to guarantee the order.

This could fix some instances of rx ring corruption due to done
bit in rx attention flag not set.

Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>

parent 38e2a644

drivers/net/wireless/ath/ath10k/htt_rx.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -97,6 +97,11 @@ static int __ath10k_htt_rx_ring_fill_n(struct ath10k_htt *htt, int num)
		}

		fail:
		/*
		* Make sure the rx buffer is updated before available buffer
		* index to avoid any potential rx ring corruption.
		*/
		mb();
		*htt->rx_ring.alloc_idx.vaddr = __cpu_to_le32(idx);
		return ret;
		}