Commit 5d3cf501 authored Nov 12, 2018 by Tetsuo Handa Committed by Greg Kroah-Hartman Jan 23, 2019

loop: Fix double mutex_unlock(&loop_ctl_mutex) in loop_control_ioctl()



commit 628bd85947091830a8c4872adfd5ed1d515a9cf2 upstream.

Commit 0a42e99b58a20883 ("loop: Get rid of loop_index_mutex") forgot to
remove mutex_unlock(&loop_ctl_mutex) from loop_control_ioctl() when
replacing loop_index_mutex with loop_ctl_mutex.

Fixes: 0a42e99b58a20883 ("loop: Get rid of loop_index_mutex")
Reported-by: syzbot <syzbot+c0138741c2290fc5e63f@syzkaller.appspotmail.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 6a8f1d8d

drivers/block/loop.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -1929,12 +1929,10 @@ static long loop_control_ioctl(struct file *file, unsigned int cmd,
		break;
		if (lo->lo_state != Lo_unbound) {
		ret = -EBUSY;
		mutex_unlock(&loop_ctl_mutex);
		break;
		}
		if (atomic_read(&lo->lo_refcnt) > 0) {
		ret = -EBUSY;
		mutex_unlock(&loop_ctl_mutex);
		break;
		}
		lo->lo_disk->private_data = NULL;