Commit 5c93f56f authored Jun 23, 2016 by Amitoj Kaur Chawla Committed by David Teigland Jun 23, 2016

dlm: Use kmemdup instead of kmalloc and memcpy



Replace calls to kmalloc followed by a memcpy with a direct call to
kmemdup.

The Coccinelle semantic patch used to make this change is as follows:
@@
expression from,to,size,flag;
statement S;
@@

-  to = \(kmalloc\|kzalloc\)(size,flag);
+  to = kmemdup(from,size,flag);
   if (to==NULL || ...) S
-  memcpy(to, from, size);

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: David Teigland <teigland@redhat.com>

parent 505ee528

fs/dlm/lowcomms.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1279,10 +1279,9 @@ static void init_local(void)
		if (dlm_our_addr(&sas, i))
		break;

		addr = kmalloc(sizeof(*addr), GFP_NOFS);
		addr = kmemdup(&sas, sizeof(*addr), GFP_NOFS);
		if (!addr)
		break;
		memcpy(addr, &sas, sizeof(*addr));
		dlm_local_addr[dlm_local_count++] = addr;
		}
		}