Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5bce833c authored by Axel Lin's avatar Axel Lin Committed by Mark Brown
Browse files

regulator: tps65217: Fix using wrong dev argument for calling of_regulator_match 



The dev parameter is the device requestiong the data.
In this case it should be &pdev->dev rather than pdev->dev.parent.

The dev parameter is used to call devm_kzalloc in of_get_regulator_init_data(),
which means this fixes a memory leak because the memory is allocated every time
probe() is called, thus it should be freed when this driver is unloaded.

Signed-off-by: default avatarAxel Lin <axel.lin@ingics.com>
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
parent 7d1f9aef

drivers/regulator/tps65217-regulator.c

+2 −2
Original line number Diff line number Diff line
@@ -305,8 +305,8 @@ static struct tps65217_board *tps65217_parse_dt(struct platform_device *pdev) 
	if (!regs)

		return NULL;



	count = of_regulator_match(pdev->dev.parent, regs,

				reg_matches, TPS65217_NUM_REGULATOR);

	count = of_regulator_match(&pdev->dev, regs, reg_matches,

				   TPS65217_NUM_REGULATOR);

	of_node_put(regs);

	if ((count < 0) || (count > TPS65217_NUM_REGULATOR))

		return NULL;