Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5b810a24 authored by Tariq Toukan's avatar Tariq Toukan Committed by Doug Ledford
Browse files

IB/uverbs: Fix leak of XRC target QPs 



The real QP is destroyed in case of the ref count reaches zero, but
for XRC target QPs this call was missed and caused to QP leaks.

Let's call to destroy for all flows.

Fixes: 0e0ec7e0 ('RDMA/core: Export ib_open_qp() to share XRC...')
Signed-off-by: default avatarTariq Toukan <tariqt@mellanox.com>
Signed-off-by: default avatarNoa Osherovich <noaos@mellanox.com>
Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent a909d3e6

drivers/infiniband/core/uverbs_main.c

+2 −5
Original line number Diff line number Diff line
@@ -262,12 +262,9 @@ static int ib_uverbs_cleanup_ucontext(struct ib_uverbs_file *file, 
			container_of(uobj, struct ib_uqp_object, uevent.uobject);



		idr_remove_uobj(&ib_uverbs_qp_idr, uobj);

		if (qp != qp->real_qp) {

			ib_close_qp(qp);

		} else {

		if (qp == qp->real_qp)

			ib_uverbs_detach_umcast(qp, uqp);

		ib_destroy_qp(qp);

		}

		ib_uverbs_release_uevent(file, &uqp->uevent);

		kfree(uqp);

	}