Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5b412fd1 authored by Thierry Escande's avatar Thierry Escande Committed by Samuel Ortiz
Browse files

NFC: Fix pn533 target mode memory leak 



In target mode, sent sk_buff were not freed in pn533_tm_send_complete

Signed-off-by: default avatarThierry Escande <thierry.escande@linux.intel.com>
Signed-off-by: default avatarSamuel Ortiz <sameo@linux.intel.com>
parent 70418e6e

drivers/nfc/pn533.c

+5 −1
Original line number Diff line number Diff line
@@ -2077,8 +2077,12 @@ static int pn533_transceive(struct nfc_dev *nfc_dev, 
static int pn533_tm_send_complete(struct pn533 *dev, void *arg,

				  u8 *params, int params_len)

{

	struct sk_buff *skb_out = arg;



	nfc_dev_dbg(&dev->interface->dev, "%s", __func__);



	dev_kfree_skb(skb_out);



	if (params_len < 0) {

		nfc_dev_err(&dev->interface->dev,

			    "Error %d when sending data",
@@ -2116,7 +2120,7 @@ static int pn533_tm_send(struct nfc_dev *nfc_dev, struct sk_buff *skb) 


	rc = pn533_send_cmd_frame_async(dev, out_frame, dev->in_frame,

					dev->in_maxlen, pn533_tm_send_complete,

					NULL, GFP_KERNEL);

					skb, GFP_KERNEL);

	if (rc) {

		nfc_dev_err(&dev->interface->dev,

			    "Error %d when trying to send data", rc);