Commit 5af2eb2f authored Oct 16, 2019 by Zhang Lixu Committed by Greg Kroah-Hartman Nov 12, 2019

HID: intel-ish-hid: fix wrong error handling in ishtp_cl_alloc_tx_ring()



[ Upstream commit 16ff7bf6dbcc6f77d2eec1ac9120edf44213c2f1 ]

When allocating tx ring buffers failed, should free tx buffers, not rx buffers.

Signed-off-by: Zhang Lixu <lixu.zhang@intel.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 35614acc

drivers/hid/intel-ish-hid/ishtp/client-buffers.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -90,7 +90,7 @@ int ishtp_cl_alloc_tx_ring(struct ishtp_cl *cl)
		return 0;
		out:
		dev_err(&cl->device->dev, "error in allocating Tx pool\n");
		ishtp_cl_free_rx_ring(cl);
		ishtp_cl_free_tx_ring(cl);
		return -ENOMEM;
		}