Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5ae65db5 authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

[media] lmedm04: use u32 instead of u64 for relative stats 



Cleanup this sparse warning:
	drivers/media/usb/dvb-usb-v2/lmedm04.c:302 lme2510_update_stats() warn: should '((255 - st->signal_sn - 161) * 3) << 8' be a 64 bit type?

Both c_tmp and s_tmp actually stores a u16 stat. Using a u64 data
there is a waste, specially on u32 archs, as 64 ints there are more
expensive.

So, change the types to u32 and do the typecast only when storing
the result.

Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent 7fd6bd9d

drivers/media/usb/dvb-usb-v2/lmedm04.c

+3 −3
Original line number Diff line number Diff line
@@ -262,7 +262,7 @@ static void lme2510_update_stats(struct dvb_usb_adapter *adap) 
	struct lme2510_state *st = adap_to_priv(adap);

	struct dvb_frontend *fe = adap->fe[0];

	struct dtv_frontend_properties *c;

	u64 s_tmp = 0, c_tmp = 0;

	u32 s_tmp = 0, c_tmp = 0;



	if (!fe)

		return;
@@ -309,11 +309,11 @@ static void lme2510_update_stats(struct dvb_usb_adapter *adap) 


	c->strength.len = 1;

	c->strength.stat[0].scale = FE_SCALE_RELATIVE;

	c->strength.stat[0].uvalue = s_tmp;

	c->strength.stat[0].uvalue = (u64)s_tmp;



	c->cnr.len = 1;

	c->cnr.stat[0].scale = FE_SCALE_RELATIVE;

	c->cnr.stat[0].uvalue = c_tmp;

	c->cnr.stat[0].uvalue = (u64)c_tmp;

}



static void lme2510_int_response(struct urb *lme_urb)