Commit 5ac5bd87 authored Sep 18, 2011 by Kevin McKinney Committed by Greg Kroah-Hartman Sep 19, 2011

Staging: bcm: Add size minimum size restrictions for IOCTL_IDLE_REQ



If IoBuffer.InputLength is zero then this will cause an Oops when
we dereference the ZERO_SIZE_PTR.  Or if it's smaller than
sizeof(struct link_request) then we would get memory corruption
when we set ->PLength in CopyBufferToControlPacket().

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent 7518b9b8

drivers/staging/bcm/Bcmchar.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -687,7 +687,9 @@ static long bcm_char_ioctl(struct file *filp, UINT cmd, ULONG arg)
		if (copy_from_user(&IoBuffer, argp, sizeof(IOCTL_BUFFER)))
		return -EFAULT;

		/* FIXME: don't accept any length from user */
		if (IoBuffer.InputLength < sizeof(struct link_request))
		return -EINVAL;

		pvBuffer = kmalloc(IoBuffer.InputLength, GFP_KERNEL);
		if (!pvBuffer)
		return -ENOMEM;