Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5aa379ec authored by Shubham Talekar's avatar Shubham Talekar Committed by Gerrit - the friendly Code Review server
Browse files

msm: vidc: Fix to prevent bus voting overflow 



computational formula for compression_ratio getting overflow;
It was due to left shifting of 16 bits;
Hence the fixed was made to prevent it.

Change-Id: I7de64527834efea6e3415c771fdc9b72acc0fd0c
Signed-off-by: default avatarShubham Talekar <stalek@codeaurora.org>
parent 1376150f

drivers/media/platform/msm/vidc/msm_vidc_clocks.c

+3 −2
Original line number Diff line number Diff line
@@ -15,6 +15,7 @@ 
#include "vidc_hfi_api.h"

#include "msm_vidc_debug.h"

#include "msm_vidc_clocks.h"

#include "./governors/fixedpoint.h"



#define MSM_VIDC_MIN_UBWC_COMPLEXITY_FACTOR (1 << 16)

#define MSM_VIDC_MAX_UBWC_COMPLEXITY_FACTOR (4 << 16)
@@ -38,7 +39,7 @@ static inline void msm_dcvs_print_dcvs_stats(struct clock_data *dcvs) 
static inline unsigned long int get_ubwc_compression_ratio(

	struct ubwc_cr_stats_info_type ubwc_stats_info)

{

	unsigned long int sum = 0, weighted_sum = 0;

	fp_t sum = 0, weighted_sum = 0;

	unsigned long int compression_ratio = 1 << 16;



	weighted_sum =
@@ -60,7 +61,7 @@ static inline unsigned long int get_ubwc_compression_ratio( 
		ubwc_stats_info.cr_stats_info6;



	compression_ratio = (weighted_sum && sum) ?

		((256 * sum) << 16) / weighted_sum : compression_ratio;

		fp_div((256 * sum), weighted_sum) : compression_ratio;



	return compression_ratio;

}