Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5a905c2d authored by Colin Ian King's avatar Colin Ian King Committed by Greg Kroah-Hartman
Browse files

ext4: unsigned int compared against zero 



commit fbbbbd2f28aec991f3fbc248df211550fbdfd58c upstream.

There are two cases where u32 variables n and err are being checked
for less than zero error values, the checks is always false because
the variables are not signed. Fix this by making the variables ints.

Addresses-Coverity: ("Unsigned compared against 0")
Fixes: 345c0dbf3a30 ("ext4: protect journal inode's blocks using block_validity")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
Signed-off-by: default avatarAshwin H <ashwinh@vmware.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 12140f9b

fs/ext4/block_validity.c

+2 −1
Original line number Diff line number Diff line
@@ -141,7 +141,8 @@ static int ext4_protect_reserved_inode(struct super_block *sb, u32 ino) 
	struct inode *inode;

	struct ext4_sb_info *sbi = EXT4_SB(sb);

	struct ext4_map_blocks map;

	u32 i = 0, err = 0, num, n;

	u32 i = 0, num;

	int err = 0, n;



	if ((ino < EXT4_ROOT_INO) ||

	    (ino > le32_to_cpu(sbi->s_es->s_inodes_count)))