Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 59e0eaaa authored by Yu Kuai's avatar Yu Kuai Committed by Greg Kroah-Hartman
Browse files

pinctrl: falcon: add missing put_device() call in pinctrl_falcon_probe() 



[ Upstream commit 89cce2b3f247a434ee174ab6803698041df98014 ]

if of_find_device_by_node() succeed, pinctrl_falcon_probe() doesn't have
a corresponding put_device(). Thus add put_device() to fix the exception
handling for this function implementation.

Fixes: e316cb2b ("OF: pinctrl: MIPS: lantiq: adds support for FALCON SoC")
Signed-off-by: default avatarYu Kuai <yukuai3@huawei.com>
Link: https://lore.kernel.org/r/20201119011219.2248232-1-yukuai3@huawei.com


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 67e32fda

drivers/pinctrl/pinctrl-falcon.c

+9 −5
Original line number Diff line number Diff line
@@ -438,24 +438,28 @@ static int pinctrl_falcon_probe(struct platform_device *pdev) 


	/* load and remap the pad resources of the different banks */

	for_each_compatible_node(np, NULL, "lantiq,pad-falcon") {

		struct platform_device *ppdev = of_find_device_by_node(np);

		const __be32 *bank = of_get_property(np, "lantiq,bank", NULL);

		struct resource res;

		struct platform_device *ppdev;

		u32 avail;

		int pins;



		if (!of_device_is_available(np))

			continue;



		if (!ppdev) {

			dev_err(&pdev->dev, "failed to find pad pdev\n");

			continue;

		}

		if (!bank || *bank >= PORTS)

			continue;

		if (of_address_to_resource(np, 0, &res))

			continue;



		ppdev = of_find_device_by_node(np);

		if (!ppdev) {

			dev_err(&pdev->dev, "failed to find pad pdev\n");

			continue;

		}



		falcon_info.clk[*bank] = clk_get(&ppdev->dev, NULL);

		put_device(&ppdev->dev);

		if (IS_ERR(falcon_info.clk[*bank])) {

			dev_err(&ppdev->dev, "failed to get clock\n");

			return PTR_ERR(falcon_info.clk[*bank]);