Commit 59d4d41f authored Jul 13, 2018 by Nicholas Mc Guire Committed by Greg Kroah-Hartman Sep 26, 2018

clk: imx6ul: fix missing of_node_put()



[ Upstream commit 11177e7a7aaef95935592072985526ebf0a3df43 ]

of_find_compatible_node() is returning a device node with refcount
incremented and must be explicitly decremented after the last use
which is right after the us in of_iomap() here.

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Fixes: 787b4271 ("clk: imx: add imx6ul clk tree support")
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 1a174288

drivers/clk/imx/clk-imx6ul.c

+1 −0

Original line number	Original line	Diff line number	Diff line
	@@ -120,6 +120,7 @@ static void __init imx6ul_clocks_init(struct device_node *ccm_node)

	np = of_find_compatible_node(NULL, NULL, "fsl,imx6ul-anatop");		np = of_find_compatible_node(NULL, NULL, "fsl,imx6ul-anatop");
	base = of_iomap(np, 0);		base = of_iomap(np, 0);
			of_node_put(np);
	WARN_ON(!base);		WARN_ON(!base);

	clks[IMX6UL_PLL1_BYPASS_SRC] = imx_clk_mux("pll1_bypass_src", base + 0x00, 14, 1, pll_bypass_src_sels, ARRAY_SIZE(pll_bypass_src_sels));		clks[IMX6UL_PLL1_BYPASS_SRC] = imx_clk_mux("pll1_bypass_src", base + 0x00, 14, 1, pll_bypass_src_sels, ARRAY_SIZE(pll_bypass_src_sels));