Commit 59915133 authored Jan 25, 2016 by Takashi Iwai

ALSA: seq: Fix incorrect sanity check at snd_seq_oss_synth_cleanup()



ALSA sequencer OSS emulation code has a sanity check for currently
opened devices, but there is a thinko there, eventually it spews
warnings and skips the operation wrongly like:
  WARNING: CPU: 1 PID: 7573 at sound/core/seq/oss/seq_oss_synth.c:311

Fix this off-by-one error.

Reported-by: Dmitry Vyukov <dvyukov@google.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 92e963f5

sound/core/seq/oss/seq_oss_synth.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -308,7 +308,7 @@ snd_seq_oss_synth_cleanup(struct seq_oss_devinfo *dp)
		struct seq_oss_synth *rec;
		struct seq_oss_synthinfo *info;

		if (snd_BUG_ON(dp->max_synthdev >= SNDRV_SEQ_OSS_MAX_SYNTH_DEVS))
		if (snd_BUG_ON(dp->max_synthdev > SNDRV_SEQ_OSS_MAX_SYNTH_DEVS))
		return;
		for (i = 0; i < dp->max_synthdev; i++) {
		info = &dp->synths[i];