Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 596e4150 authored by Stephen Hemminger's avatar Stephen Hemminger Committed by David S. Miller
Browse files

[IPV4] devinet: show all addresses assigned to interface 

Bug: http://bugzilla.kernel.org/show_bug.cgi?id=8876



Not all ips are shown by "ip addr show" command when IPs number assigned to an
interface is more than 60-80 (in fact it depends on broadcast/label etc
presence on each address).

Steps to reproduce:
It's terribly simple to reproduce:

# for i in $(seq 1 100); do ip ad add 10.0.$i.1/24 dev eth10 ; done
# ip addr show

this will _not_ show all IPs.
Looks like the problem is in netlink/ipv4 message processing.

This is fix from bug submitter, it looks correct.

Signed-off-by: default avatarStephen Hemminger <shemminger@linux-foundation.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ef8aef55

net/ipv4/devinet.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -1193,7 +1193,7 @@ static int inet_dump_ifaddr(struct sk_buff *skb, struct netlink_callback *cb) 
		for (ifa = in_dev->ifa_list, ip_idx = 0; ifa;

		for (ifa = in_dev->ifa_list, ip_idx = 0; ifa;

		     ifa = ifa->ifa_next, ip_idx++) {

		     ifa = ifa->ifa_next, ip_idx++) {

			if (ip_idx < s_ip_idx)

			if (ip_idx < s_ip_idx)

				goto cont;

				continue;

			if (inet_fill_ifaddr(skb, ifa, NETLINK_CB(cb->skb).pid,

			if (inet_fill_ifaddr(skb, ifa, NETLINK_CB(cb->skb).pid,

					     cb->nlh->nlmsg_seq,

					     cb->nlh->nlmsg_seq,

					     RTM_NEWADDR, NLM_F_MULTI) <= 0)

					     RTM_NEWADDR, NLM_F_MULTI) <= 0)