Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 58dadcdb authored by Julia Lawall's avatar Julia Lawall Committed by Mark Fasheh
Browse files

fs/ocfs2/aops.c: test for IS_ERR rather than 0 



The function ocfs2_start_trans always returns either a valid pointer or a
value made with ERR_PTR, so its result should be tested with IS_ERR, not
with a test for 0.

Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarMark Fasheh <mfasheh@suse.com>
parent 4d0ddb2c

fs/ocfs2/aops.c

+3 −3
Original line number Diff line number Diff line
@@ -467,11 +467,11 @@ handle_t *ocfs2_start_walk_page_trans(struct inode *inode, 
							 unsigned to)

{

	struct ocfs2_super *osb = OCFS2_SB(inode->i_sb);

	handle_t *handle = NULL;

	handle_t *handle;

	int ret = 0;



	handle = ocfs2_start_trans(osb, OCFS2_INODE_UPDATE_CREDITS);

	if (!handle) {

	if (IS_ERR(handle)) {

		ret = -ENOMEM;

		mlog_errno(ret);

		goto out;
@@ -487,7 +487,7 @@ handle_t *ocfs2_start_walk_page_trans(struct inode *inode, 
	}

out:

	if (ret) {

		if (handle)

		if (!IS_ERR(handle))

			ocfs2_commit_trans(osb, handle);

		handle = ERR_PTR(ret);

	}