Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 58b48576 authored by Andrew Vasquez's avatar Andrew Vasquez Committed by James Bottomley
Browse files

[SCSI] qla2xxx: Correct inadvertent loop state transitions during port-update handling. 



Transitioning to a LOOP_UPDATE loop-state could cause the driver
to miss normal link/target processing.  LOOP_UPDATE is a crufty
artifact leftover from at time the driver performed it's own
internal command-queuing.  Safely remove this state.

Signed-off-by: default avatarAndrew Vasquez <andrew.vasquez@qlogic.com>
Signed-off-by: default avatarChad Dupuis <chad.dupuis@qlogic.com>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent 3553d343

drivers/scsi/qla2xxx/qla_init.c

+0 −3
Original line number Diff line number Diff line
@@ -3838,15 +3838,12 @@ qla2x00_loop_resync(scsi_qla_host_t *vha) 
		req = vha->req;

	rsp = req->rsp;



	atomic_set(&vha->loop_state, LOOP_UPDATE);

	clear_bit(ISP_ABORT_RETRY, &vha->dpc_flags);

	if (vha->flags.online) {

		if (!(rval = qla2x00_fw_ready(vha))) {

			/* Wait at most MAX_TARGET RSCNs for a stable link. */

			wait_time = 256;

			do {

				atomic_set(&vha->loop_state, LOOP_UPDATE);



				/* Issue a marker after FW becomes ready. */

				qla2x00_marker(vha, req, rsp, 0, 0,

					MK_SYNC_ALL);

drivers/scsi/qla2xxx/qla_isr.c

+0 −1
Original line number Diff line number Diff line
@@ -719,7 +719,6 @@ qla2x00_async_event(scsi_qla_host_t *vha, struct rsp_que *rsp, uint16_t *mb) 
			vha->flags.rscn_queue_overflow = 1;

		}



		atomic_set(&vha->loop_state, LOOP_UPDATE);

		atomic_set(&vha->loop_down_timer, 0);

		vha->flags.management_server_logged_in = 0;