Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 589f6a90 authored by Axel Lin's avatar Axel Lin Committed by Mark Brown
Browse files

spi: sc18is602: Remove sc18is602_setup() because it is done by spi core 



The checking for spi->mode is done in the implementation of spi_setup().
Calling sc18is602_check_transfer(spi, NULL, 0) is pointless because
the code is equivent to checking if spi->max_speed_hz is 0.
Note, sc18is602_check_transfer actually allows spi->max_speed_hz is 0
if t->speed_hz is set. So return error in sc18is602_setup() when
spi->max_speed_hz is 0 does not make sense.

Signed-off-by: default avatarAxel Lin <axel.lin@ingics.com>
Acked-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarMark Brown <broonie@linaro.org>
parent 38dbfb59

drivers/spi/spi-sc18is602.c

+0 −9
Original line number Diff line number Diff line
@@ -245,14 +245,6 @@ static int sc18is602_transfer_one(struct spi_master *master, 
	return status;

}



static int sc18is602_setup(struct spi_device *spi)

{

	if (spi->mode & ~(SPI_CPHA | SPI_CPOL | SPI_LSB_FIRST))

		return -EINVAL;



	return sc18is602_check_transfer(spi, NULL, 0);

}



static int sc18is602_probe(struct i2c_client *client,

			   const struct i2c_device_id *id)

{
@@ -306,7 +298,6 @@ static int sc18is602_probe(struct i2c_client *client, 
	master->bus_num = client->adapter->nr;

	master->mode_bits = SPI_CPHA | SPI_CPOL | SPI_LSB_FIRST;

	master->bits_per_word_mask = SPI_BPW_MASK(8);

	master->setup = sc18is602_setup;

	master->transfer_one_message = sc18is602_transfer_one;

	master->dev.of_node = np;