Commit 58625edf authored Aug 02, 2016 by Wei Yongjun Committed by Michael S. Tsirkin Aug 09, 2016

virtio: fix memory leak in virtqueue_add()



When using the indirect buffers feature, 'desc' is allocated in
virtqueue_add() but isn't freed before leaving on a ring full error,
causing a memory leak.

For example, it seems rather clear that this can trigger
with virtio net if mergeable buffers are not used.

Cc: stable@vger.kernel.org
Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

parent 29b4817d

drivers/virtio/virtio_ring.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -327,6 +327,8 @@ static inline int virtqueue_add(struct virtqueue *_vq,
		* host should service the ring ASAP. */
		if (out_sgs)
		vq->notify(&vq->vq);
		if (indirect)
		kfree(desc);
		END_USE(vq);
		return -ENOSPC;
		}