Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 57a37144 authored by J. Bruce Fields's avatar J. Bruce Fields
Browse files

nfsd4: CREATE_SESSION should update backchannel immediately



nfsd4_probe_callback kicks off some work that will eventually run
nfsd4_process_cb_update and update the session flags.  In theory we
could process a following SEQUENCE call before that update happens
resulting in flags that don't accurately represent, for example, the
lack of a backchannel.

Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
parent 22cb4385
Loading
Loading
Loading
Loading
+2 −4
Original line number Diff line number Diff line
@@ -1223,10 +1223,8 @@ static void nfsd4_init_conn(struct svc_rqst *rqstp, struct nfsd4_conn *conn, str
	if (ret)
		/* oops; xprt is already down: */
		nfsd4_conn_lost(&conn->cn_xpt_user);
	if (conn->cn_flags & NFS4_CDFC4_BACK) {
		/* callback channel may be back up */
		nfsd4_probe_callback(ses->se_client);
	}
	/* We may have gained or lost a callback channel: */
	nfsd4_probe_callback_sync(ses->se_client);
}

static struct nfsd4_conn *alloc_conn_from_crses(struct svc_rqst *rqstp, struct nfsd4_create_session *cses)