Commit 574e543f authored Dec 22, 2017 by Thomas Gleixner Committed by Greg Kroah-Hartman Jan 02, 2018

timers: Invoke timer_start_debug() where it makes sense



commit fd45bb77ad682be728d1002431d77b8c73342836 upstream.

The timer start debug function is called before the proper timer base is
set. As a consequence the trace data contains the stale CPU and flags
values.

Call the debug function after setting the new base and flags.

Fixes: 500462a9 ("timers: Switch to a non-cascading wheel")
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Sebastian Siewior <bigeasy@linutronix.de>
Cc: rt@linutronix.de
Cc: Paul McKenney <paulmck@linux.vnet.ibm.com>
Cc: Anna-Maria Gleixner <anna-maria@linutronix.de>
Link: https://lkml.kernel.org/r/20171222145337.792907137@linutronix.de


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent d840687a

kernel/time/timer.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1019,8 +1019,6 @@ __mod_timer(struct timer_list *timer, unsigned long expires, bool pending_only)
		if (!ret && pending_only)
		goto out_unlock;

		debug_activate(timer, expires);

		new_base = get_target_base(base, timer->flags);

		if (base != new_base) {
		@@ -1044,6 +1042,8 @@ __mod_timer(struct timer_list *timer, unsigned long expires, bool pending_only)
		}
		}

		debug_activate(timer, expires);

		timer->expires = expires;
		/*
		* If 'idx' was calculated above and the base time did not advance